Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement StapledMemoryChannel #1784

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

belm0
Copy link
Member

@belm0 belm0 commented Nov 1, 2020

partially addresses #719

@codecov
Copy link

codecov bot commented Nov 1, 2020

Codecov Report

Merging #1784 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1784   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         114      114           
  Lines       14453    14486   +33     
  Branches     1105     1106    +1     
=======================================
+ Hits        14401    14434   +33     
  Misses         37       37           
  Partials       15       15           
Impacted Files Coverage Δ
trio/__init__.py 100.00% <ø> (ø)
trio/_channel.py 100.00% <100.00%> (ø)
trio/tests/test_channel.py 100.00% <100.00%> (ø)

@pquentin
Copy link
Member

pquentin commented Nov 2, 2020

It looks like codecov was down when you submitted that pull request. Closing/reopening

@pquentin pquentin closed this Nov 2, 2020
@pquentin pquentin reopened this Nov 2, 2020
@pquentin
Copy link
Member

pquentin commented Nov 2, 2020

@belm0 Codecov now complains about aclose() not being tested

@pquentin
Copy link
Member

pquentin commented Nov 2, 2020

3.9.0-rc2 stalled when installing dependencies, closing/reopening...

@pquentin pquentin closed this Nov 2, 2020
@pquentin pquentin reopened this Nov 2, 2020
@belm0
Copy link
Member Author

belm0 commented Nov 6, 2020

@njsmith please take a look

I started with StapledMemoryChannel rather than StapledChannel, since my use case is needing the nowait methods. Not sure whether it's worth making a MemoryChannel abc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants