Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed unhelpful error message in from_thread_run functions. #1513

Merged
merged 16 commits into from
May 21, 2020
Merged

Fixed unhelpful error message in from_thread_run functions. #1513

merged 16 commits into from
May 21, 2020

Commits on May 12, 2020

  1. Added helpful error message in the case the user passed incorrect typ… 

    …e of function to both "from_thread_run" functions.
    Guillermo Rodriguez committed May 12, 2020
    Configuration menu
    Copy the full SHA
    96cdeb2 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2020

  1. Extracted "coroutine or TypeError" logic from Runner.spawn_impl, move… 

    …d it to trio._util. Used it in trio.from_thread_run.
    Guillermo Rodriguez committed May 13, 2020
    Configuration menu
    Copy the full SHA
    015b220 View commit details
    Browse the repository at this point in the history

  2. Added sync check

    Guillermo Rodriguez committed May 13, 2020
    Configuration menu
    Copy the full SHA
    126f7f4 View commit details
    Browse the repository at this point in the history

  3. Ran code formatter and added comments.

    Guillermo Rodriguez committed May 13, 2020
    Configuration menu
    Copy the full SHA
    417ba5b View commit details
    Browse the repository at this point in the history

  4. Added coroutine_or_error test.

    Guillermo Rodriguez committed May 13, 2020
    Configuration menu
    Copy the full SHA
    dc06cad View commit details
    Browse the repository at this point in the history

  5. Added TypeError tests to from_thread_run and from_thread_run_sync

    Guillermo Rodriguez committed May 13, 2020
    Configuration menu
    Copy the full SHA
    dc1e5b8 View commit details
    Browse the repository at this point in the history

  6. Moved comprehensive test of callable from test_run.py to test_util.py

    Guillermo Rodriguez committed May 13, 2020
    Configuration menu
    Copy the full SHA
    5e4145d View commit details
    Browse the repository at this point in the history

Commits on May 14, 2020

  1. Added error message check

    Guillermo Rodriguez committed May 14, 2020
    Configuration menu
    Copy the full SHA
    c74a829 View commit details
    Browse the repository at this point in the history

  2. Marked some function stubs with #pragma no cover

    Guillermo Rodriguez committed May 14, 2020
    Configuration menu
    Copy the full SHA
    ad27338 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2020

  1. Fixed comment on spawn_impl. Moved ignore_coroutine_never_awaited_war… 

    …nings to tutil. Added raised error test to nursery.start_soon & _core.run. coroutine_or_error now takes variable arguments. Added RuntimeWarning protection to from_thread_run_sync & coroutine_or_error. Fixed typos in comments.
    Guillermo Rodriguez committed May 15, 2020
    Configuration menu
    Copy the full SHA
    57c1080 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2020

  1. Fixed/added some comments. Removed unnecessary ignore_coroutine_never… 

    …_awaited_warnings. Better naming of return value in from_thread_run_sync.
    Guillermo Rodriguez committed May 16, 2020
    Configuration menu
    Copy the full SHA
    f4c11e9 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2020

  1. Fixed a comment and other formatting issues.

    Guillermo Rodriguez committed May 18, 2020
    Configuration menu
    Copy the full SHA
    28b08d1 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2020

  1. Remove another extra blank line

    @oremanj
    oremanj committed May 20, 2020
    Configuration menu
    Copy the full SHA
    0f809d0 View commit details
    Browse the repository at this point in the history

  2. Remove a couple more of the extra added blank lines

    @oremanj
    oremanj committed May 20, 2020
    Configuration menu
    Copy the full SHA
    7a71a85 View commit details
    Browse the repository at this point in the history

  3. Added newsfragment

    Guillermo Rodriguez committed May 20, 2020
    Configuration menu
    Copy the full SHA
    7de4c84 View commit details
    Browse the repository at this point in the history

  4. Update newsfragments/1244.bugfix.rst 

    Co-authored-by: Joshua Oreman <[email protected]>
    @oremanj
    Guillermo Rodriguez and oremanj committed May 20, 2020
    Configuration menu
    Copy the full SHA
    f77c200 View commit details
    Browse the repository at this point in the history