Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make supports custom python interpreter #83

Merged
merged 1 commit into from
Nov 16, 2018
Merged

make supports custom python interpreter #83

merged 1 commit into from
Nov 16, 2018

Conversation

belm0
Copy link
Member

@belm0 belm0 commented Nov 9, 2018

No description provided.

@belm0 belm0 mentioned this pull request Nov 9, 2018
Closed
@belm0 belm0 requested a review from mehaase November 10, 2018 00:26
@mehaase
Copy link
Contributor

mehaase commented Nov 10, 2018

What's the benefit of this versus setting up multiple virtualenvs?

I tried testing it locally and it seems fine. I'm just curious about the motivation.

@belm0
Copy link
Member Author

belm0 commented Nov 10, 2018

it allows make test etc. even if you don't have virtualenv installed, e.g. if your python interpreter is python3.

@coveralls
Copy link

coveralls commented Nov 10, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 94

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 92.098%
Files with Coverage Reduction New Missed Lines %
trio_websocket/_impl.py 3 92.88%
Totals Coverage Status
Change from base Build 92: -0.5%
Covered Lines: 338
Relevant Lines: 367
💛 - Coveralls

@belm0
Copy link
Member Author

belm0 commented Nov 10, 2018

CI passes, coverage reports regression that appears unrelated (filed #88)

@mehaase mehaase merged commit 768ff39 into python-trio:master Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehaase mehaase Awaiting requested review from mehaase

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@belm0 @mehaase @coveralls