Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Docs) Added type = "file" reference [tool.poetry.scripts] #9572

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

RobertoRoos
Copy link
Contributor

@RobertoRoos RobertoRoos commented Jul 23, 2024

Pull Request Check List

Resolves: #9510

  • Added tests for changed code.
  • Updated documentation for changed code.

@RobertoRoos RobertoRoos force-pushed the bugfix/docs-scripts branch from 1f643b2 to 7b10d45 Compare July 23, 2024 11:22
docs/pyproject.md Outdated Show resolved Hide resolved
@evilhamsterman
Copy link

@RobertoRoos the type option has more possible values than just type="file" there's also at least type="console" which at one point was at least mentioned in the documentation but was later removed even though it appears to still be a valid value https://github.com/orgs/python-poetry/discussions/8436

@yeoffrey
Copy link

yeoffrey commented Aug 7, 2024

@RobertoRoos the type option has more possible values than just type="file" there's also at least type="console" which at one point was at least mentioned in the documentation but was later removed even though it appears to still be a valid value https://github.com/orgs/python-poetry/discussions/8436

If this PR just wants to focus on the file option, I'm fine to add the type option in a follow up, which would close #9608

@RobertoRoos
Copy link
Contributor Author

If this PR just wants to focus on the file option, I'm fine to add the type option in a follow up, which would close #9608

That would be my preference. Personally I have no idea what other options there are and what their implications would be.

@yeoffrey
Copy link

yeoffrey commented Jan 7, 2025

What is the status of this PR? Can we merge this?

@abn abn force-pushed the bugfix/docs-scripts branch from ffeec36 to 9400e70 Compare January 16, 2025 02:07
docs/pyproject.md Show resolved Hide resolved
docs/pyproject.md Outdated Show resolved Hide resolved
docs/pyproject.md Outdated Show resolved Hide resolved
@RobertoRoos RobertoRoos force-pushed the bugfix/docs-scripts branch 2 times, most recently from 683a713 to 70802ff Compare January 20, 2025 07:28
@abn abn enabled auto-merge (squash) January 22, 2025 13:01
@abn abn force-pushed the bugfix/docs-scripts branch from 70802ff to 12bd0d8 Compare January 22, 2025 13:01
@abn abn merged commit 8f95399 into python-poetry:main Jan 22, 2025
59 checks passed
@RobertoRoos RobertoRoos deleted the bugfix/docs-scripts branch January 22, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing documentation for type = "file" under tool.poetry.scripts
6 participants