-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: adapt tests to cosmetic changes caused by poetry-core#826 #10110
Conversation
Reviewer's Guide by SourceryThis pull request adapts tests to cosmetic changes caused by poetry-core#826. The changes involve updating the expected output of the tests to match the new format of the dependency markers generated by poetry-core. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @radoering - I've reviewed your changes - here's some feedback:
Overall Comments:
- Using a personal fork of poetry-core could cause maintenance issues. What's the timeline for getting these changes merged upstream into python-poetry/poetry-core?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@@ -1989,71 +1989,37 @@ def test_solver_duplicate_dependencies_with_overlapping_markers_complex( | |||
], | |||
) | |||
opencv_requires = {dep.to_pep_508() for dep in ops[-1].package.requires} | |||
expectation = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notably, I removed the distinction between "concise solution" and "current solution" because we have reached a solution which is even more concise than the "concise solution".
1007cfe
to
b916a2a
Compare
b916a2a
to
d9a6b81
Compare
see issue title
The
poetry-plugin-export
failures are caused by cosmetic changes. The tests are fixed in python-poetry/poetry-plugin-export#321. We should probably merge this PR with failing downstream tests and switch from the released poetry-core version to the main branch afterwards. (I changed the CI to use the main branch ofpoetry-plugin-export
instead the latest release.)Summary by Sourcery
Tests: