-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test): mock get_vcs correctly #809
Conversation
Reviewer's Guide by SourceryThis pull request mocks the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @abn - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Previously, the test suite relied on the test environment to be the same as that of a developer and hence implicitly providing a git boundary. This allowed for certain test cases using fixtures to fail when tests are run from the release sdist. This change mocks `get_vcs` to ensure that these cases pass as expected. Resolves: python-poetry/poetry#9967
Previously, the test suite relied on the test environment to be the same as that of a developer and hence implicitly providing a git boundary. This allowed for certain test cases using fixtures to fail when tests are run from the release sdist. This change mocks
get_vcs
to ensure that these cases pass as expected.Resolves: python-poetry/poetry#9967
Summary by Sourcery
Tests:
get_vcs
to ensure that test cases using fixtures pass as expected when tests are run from the release sdist.