Fix concurrent map writes in handleUpdates by adding mutex protection for inputGroupCalls #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bot was crashing with
fatal error: concurrent map writesduring group call events. This happened because theinputGroupCallsmap was being accessed from multiple goroutines at the same time. It was being written insideUpdateGroupCallwhile other parts of the code likeOnRequestBroadcastTimestamp,OnRequestBroadcastPart, andOnUpgradewere reading from it. That race condition caused the random panics.What I changed
inputGroupCallsMutex(sync.RWMutex) to theContextstruct.inputGroupCallswith proper locking:UpdateGroupCall,getInputGroupCallconvertGroupCallId,Stop,joinPresentationFixes #36
Example