changed warning raised by async def to error #12346
Open
+27
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
reviewed
May 21, 2024
There was a problem hiding this comment.
👋 Hi Phebe! This looks good to me overall - three things to do:
- Moving the exception definition, as below
- Doing the various TODOs in comments
- Edit the top comment to link to the issue for awareness and auto-closing, and briefly describe the issue.
Comment on lines
-1
to
2
| from typing import final | ||
|
|
||
|
|
||
| @final | ||
| class UsageError(Exception): | ||
| """Error in pytest usage or invocation.""" |
There was a problem hiding this comment.
Let's try to keep this - define PytestUnhandledCoroutineError in this file, and then do UsageError = final(UsageError) below that to keep the runtime effect.
|
Hi folks, Sorry why is this being done? Is there an issue related to it? |
|
Suggested in #11372 🙂 (and we're at the PyCon US sprints, so most communication about this has been verbal instead of online) |
|
Ahh OK, no worries, thanks @Zac-HD! If possible it helps adding the issue number in the PR description for context. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.