Add tensorflow and pytorch random seed setting & Update requirements. #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why did you close this? I started reviewing and tidying last night. I think it is a great PR, thank you very much. |
I tried adding pytorch and tensorflow requirements to pass the test, but it seems I did something wrong. This PR failed checks. |
|
Should I resubmit this PR? |
|
You didn’t mess anything up. The requirements are compiled on the OS you run I will try come up with a solution here, perhaps adding tensorflow to the |
|
Maybe you can use Thanks for your explanation! |
|
How is this PR going? |
|
I will work on it when I can. Please do not ping. It is not helpful and you should have no expectation of free service. If you are going to post a message, provide information, such as "I tried using my fork in a project and it worked well" or similar. |
Tests and README are included. Add support for setting tensorflow and pytorch random seed. It can help detect flaky tests due to the randomness, provide reproducibility. Co-Authored-By: Saikat Dutta <[email protected]>
for more information, see https://pre-commit.ci
|
Python 3.12 has a segmentation fault, both locally and on CI. TracebackThis occurs reliably and disappears when removing the |
|
Yes, I'm trying to do so. But I'm not sure how to create a minimal example of this case. I noticed that except Python 3.12, other versions of CI worked well. With the below dependencies installed: While the Python 3.12 CI failed with the below dependencies installed: which |
|
Huh, interesting. It would be surprising though if the missing package caused the segmentation fault. A segfault is when code reaches for memory outside of its allotted area. |
|
Please don’t just close PRs when you give up. I may find the time to finish this, or another contributor may be interested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests and README are included.
Add support for setting tensorflow and pytorch random seed. It can help detect flaky tests due to the randomness, and provide reproducibility.
Reference:
[1] Dutta, Saikat, et al. "Detecting flaky tests in probabilistic and machine learning applications." Proceedings of the 29th ACM SIGSOFT international symposium on software testing and analysis. 2020.