Avoid mutable global state in SettingsWrapper
#1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamchainz
reviewed
Nov 10, 2023
| @@ -498,7 +497,9 @@ def async_rf() -> django.test.AsyncRequestFactory: | |||
|
|
|||
|
|
|||
| class SettingsWrapper: | |||
| _to_restore: ClassVar[list[Any]] = [] | |||
| def __init__(self) -> None: | |||
| self._to_restore: list[django.test.override_settings] | |||
There was a problem hiding this comment.
The type declaration can remain at the class level, like in a stub. IMO a little more readable.
There was a problem hiding this comment.
My idea was to make it look like self._to_restore: list[django.test.override_settings] = []
There was a problem hiding this comment.
Yeah fair, I guess type checkers support it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.