Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix from_spharapy naming in SimplicialComplex #403

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

luisfpereira
Copy link
Contributor

This PR fixes a typo in SimplicialComplex.from_spharapy (making it consistent with SimplicialComplex.to_spharapy and the library name).

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.90%. Comparing base (3540143) to head (7a75a46).
Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
+ Coverage   97.77%   97.90%   +0.12%     
==========================================
  Files          38       40       +2     
  Lines        3557     3667     +110     
==========================================
+ Hits         3478     3590     +112     
+ Misses         79       77       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhajij mhajij self-requested a review November 21, 2024 19:16
Copy link
Member

@ffl096 ffl096 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the old function name as deprecated function that calls the new function. No need to break user code here :)

@ffl096 ffl096 added the bug Something isn't working label Nov 30, 2024
@ffl096 ffl096 added this to the 0.1.2 milestone Nov 30, 2024
@ffl096 ffl096 merged commit 6a30ac8 into pyt-team:main Jan 3, 2025
13 checks passed
@ffl096 ffl096 modified the milestones: 0.1.2, 0.2.0 Jan 3, 2025
@luisfpereira luisfpereira deleted the fix-typo-spharapy branch January 3, 2025 16:39
@luisfpereira
Copy link
Contributor Author

Thanks for finishing and merging this @ffl096. (I've completely forgotten I had it open.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants