Add protection against devendored packaging. #13057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Thanks a lot for the quick reaction @freakboy3742 ! Let's wait a bit to see if a |
Understood - it didn't take much effort to get this up. I mostly just wanted to make sure the option was on the table if reverting was starting to look like a possibility. If this PR ends up going into the bit bucket, I'm fine with that, too, |
Open
|
Closing on the basis that packaging 24.2 has been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #12962 introduced a patch adding iOS support that included a vendored component that has been submitted and accepted upstream, but not yet included in a formal release.
This breaks for uses that use devendored versions of packaging.
This adds an import catch so that devendored installs won't break. They won't have iOS support, but they won't break.
Fixes #13053.