Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support test-groups #2063

Merged
merged 5 commits into from
Nov 4, 2024
Merged

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Oct 30, 2024

Supporting test-groups. Fix #2057.

@henryiii henryiii force-pushed the hernyiii/feat/test-groups branch 3 times, most recently from ce9b4d0 to 524cd1c Compare October 30, 2024 19:35
Signed-off-by: Henry Schreiner <[email protected]>
Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @henryiii ! Much easier than I expected with the dependency_groups package :)

cibuildwheel/options.py Outdated Show resolved Hide resolved
cibuildwheel/options.py Outdated Show resolved Hide resolved
cibuildwheel/options.py Outdated Show resolved Hide resolved
cibuildwheel/options.py Outdated Show resolved Hide resolved
docs/options.md Outdated Show resolved Hide resolved
Copy link
Member

@mayeut mayeut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but there are still some places using , instead of as a separator.

docs/options.md Outdated Show resolved Hide resolved
docs/options.md Outdated Show resolved Hide resolved
docs/options.md Outdated Show resolved Hide resolved
unit_test/options_toml_test.py Outdated Show resolved Hide resolved
unit_test/options_toml_test.py Outdated Show resolved Hide resolved
Co-authored-by: Matthieu Darbois <[email protected]>
cibuildwheel/projectfiles.py Outdated Show resolved Hide resolved
mayeut
mayeut previously approved these changes Nov 3, 2024
@mayeut mayeut merged commit cc1d977 into pypa:main Nov 4, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for PEP 735 dependency groups as test requirements ?
3 participants