-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Walk directories in sorted order for reproducibility #517
Conversation
* recurse directories in sorted order * recurse top-level *.dist-info/ directories last * list filenames in sorted order * list top-level *.dist-info/RECORD files last
There is an additional nit that would be trivial to address in this PR. Currently, auditwheel outputs zip files using the usual convention of storing directories as an entry of zero bytes with name ending in "/". This is exactly what the What we could do (with a one-line change in this PR) is to still store subdirectories, but only if they are empty. Again, this is not what |
This PR covers #507 and provides additional features (.dist-info directories last, .dist-info/RECORD files last) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #517 +/- ##
==========================================
+ Coverage 92.35% 92.47% +0.12%
==========================================
Files 20 20
Lines 1268 1289 +21
Branches 244 250 +6
==========================================
+ Hits 1171 1192 +21
Misses 56 56
Partials 41 41 ☔ View full report in Codecov by Sentry. |
Removing entries for non-empty folders also removes the permissions attribute for those. I'm gonna revert this for now. |
@mayeut Maybe you want to keep the test for empty folders? |
This reverts commit 25b3dd1.
thanks @dalcinl |
Implement a new utility function wrapping
os.walk
with the following modifications: