Include node on typedoc command #297
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #285
I considered updating
search_node_modulesto return a command that may or may not include"node"but since including it fixes the Windows issue without breaking other platforms I went with this smaller change instead. This is also consistent with thejsdocinvocation where"node"is always part of the command.On my windows machine the version call succeeds now but the project I'm testing it on is throwing an unrelated error about ESM URL schemes. Because of that I still haven't gotten a successful run after my changes, working on it now.
nox is also causing errors when I run it locally so after I get a successful run I'll try and check the tests locally with WSL.