Skip to content

Conversation

@evenharder
Copy link
Contributor

This PR replaces typer usage with click.
Related issue: pyodide-build #204

Compared to the previous behavior of typer, the message width is set to 80 (default value of click).
Additionally, some of the subcommand help messages are shortened as well (which seems be click's policy).
Would it be better to display the full help text for subcommands?

Below are some of the outputs.

$ pyodide
(...)
 Registered by auditwheel_emscripten:
  auditwheel  Auditwheel-like tool for emscripten wheels and shared...

$ pyodide auditwheel repair --help
Usage: pyodide auditwheel repair [OPTIONS] WHEEL_FILE

  Repair a wheel file: copy shared libraries to the wheel directory.

  Arguments:
      WHEEL_FILE: Path to wheel file. (required)

Options:
  --libdir PATH             Path to the directory containing the shared
                            libraries.  [default: lib]
  --output-dir PATH         Directory to output repaired wheel or shared
                            library. (default: overwrite the input file)
  -r, --with-runtime-paths  Show runtime paths.
  --help                    Show this message and exit.

@ryanking13
Copy link
Member

Additionally, some of the subcommand help messages are shortened as well (which seems be click's policy).
Would it be better to display the full help text for subcommands?

Yes, could you please add a short_help for that? I think something like Auditwheel-like tool for emscripten wheels should be enough.

Copy link
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left a minor comment but it looks good overall.

pyproject.toml Outdated
dependencies = [
"leb128",
"packaging",
"pyodide-cli",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the minimum version of pyodide-cli accordingly.

@ryanking13
Copy link
Member

@evenharder I updated the dependency. Thanks!

@ryanking13 ryanking13 merged commit e039a06 into pyodide:main Dec 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants