Allow debug evaling IR logp graphs #7666
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
allow_debugging_logp_graphs
branch
from
2fed5fd to
0fba15c
Compare
ricardoV94
commented
Jan 30, 2025
| @@ -236,13 +236,16 @@ class ValuedRV(Op): | |||
| and breaking the dependency of `b` on `a`. The new nodes isolate the graphs between conditioning points. | |||
| """ | |||
|
|
|||
| view_map = {0: [0]} | |||
There was a problem hiding this comment.
Needs view_map so PyTensor knows not to do inplace operations on this. The other Op already had the view_map defined
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7666 +/- ##
=======================================
Coverage 92.70% 92.70%
=======================================
Files 107 107
Lines 18391 18397 +6
=======================================
+ Hits 17049 17055 +6
Misses 1342 1342
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user on discourse recently raised the question of why we can't eval logp graphs during their construction. We have some tagging Ops that raise on the perform method, that prevent this.
https://discourse.pymc.io/t/how-to-implement-bivariate-poisson-logbp/16400/7?u=ricardov94
This PR allows evaluating them, but issues a warning.
📚 Documentation preview 📚: https://pymc--7666.org.readthedocs.build/en/7666/