Fix invalid-envvar-default to flag os.environ.get
#10094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #10094 +/- ##
=======================================
Coverage 95.80% 95.80%
=======================================
Files 174 174
Lines 18962 18962
=======================================
Hits 18166 18166
Misses 796 796
|
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 4388b82 |
Pierre-Sassoulas
added
the
False Negative π¦
DanielNoord
reviewed
Nov 23, 2024
harupy
commented
Nov 23, 2024
| @@ -30,7 +30,7 @@ | |||
| THREADING_THREAD = "threading.Thread" | |||
| COPY_COPY = "copy.copy" | |||
| OS_ENVIRON = "os._Environ" | |||
| ENV_GETTERS = ("os.getenv",) | |||
| ENV_GETTERS = ("os.getenv", "os.environ.get") | |||
There was a problem hiding this comment.
I thought this would fix the issue but it actually doesn't.
|
@harupy You asked for review but haven't changed any code. What would you like me to review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Refs #10092
Closes #10092