Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test requirements] Pin numpy below 2.0.0 #2457

Merged
merged 2 commits into from
Jul 7, 2024
Merged

[test requirements] Pin numpy below 2.0.0 #2457

merged 2 commits into from
Jul 7, 2024

Conversation

jacobtylerwalls
Copy link
Member

Refs #2442

@jacobtylerwalls jacobtylerwalls added the Maintenance Discussion or action around maintaining astroid or the dev workflow label Jul 6, 2024
@jacobtylerwalls jacobtylerwalls changed the title Pin numpy below 2.0.0 [test requirements] Pin numpy below 2.0.0 Jul 6, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.74%. Comparing base (7b9942f) to head (31d1954).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2457      +/-   ##
==========================================
+ Coverage   92.72%   92.74%   +0.01%     
==========================================
  Files          94       94              
  Lines       10993    10993              
==========================================
+ Hits        10193    10195       +2     
+ Misses        800      798       -2
Flag Coverage Δ
linux 92.62% <ø> (+0.01%) ⬆️
pypy 92.74% <ø> (+0.01%) ⬆️
windows 92.72% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Jul 7, 2024
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be fun to upgrade everything to 2. Maybe it's time to create a pylint-numpy plugin.. I'm not using numpy heavily at work anymore so I don't see any problems myself yet.

@jacobtylerwalls jacobtylerwalls merged commit 314e08b into main Jul 7, 2024
18 checks passed
@jacobtylerwalls jacobtylerwalls deleted the pin-numpy branch July 7, 2024 12:44
@jacobtylerwalls
Copy link
Member Author

We need to backport this.

@github-actions github-actions bot mentioned this pull request Jul 8, 2024
Merged
@Pierre-Sassoulas Pierre-Sassoulas added the Needs backport Needs to be cherry-picked on the current patch version by an astroid's maintainer label Jul 8, 2024
@jacobtylerwalls jacobtylerwalls added backported Assigned once the backport is done and removed Needs backport Needs to be cherry-picked on the current patch version by an astroid's maintainer labels Jul 9, 2024
@jacobtylerwalls jacobtylerwalls added this to the 3.2.3 milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
backported Assigned once the backport is done Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Milestone
3.2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobtylerwalls @Pierre-Sassoulas