Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid first time startup costs in tests #17

Merged
merged 2 commits into from
Nov 17, 2020
Merged

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Nov 17, 2020

Resolves #14

To avoid startup costs that are associated with the first time the tests are run, run the command once first to make sure everything is setup in the environment

* Run pyhf-validation --version once before test to avoid first run post install startup costs

@matthewfeickert matthewfeickert self-assigned this Nov 17, 2020
@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #17 (37c4288) into master (e1f4a71) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   90.90%   90.90%           
=======================================
  Files           3        3           
  Lines          11       11           
=======================================
  Hits           10       10           
  Misses          1        1           
Flag Coverage Δ
unittests 90.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1f4a71...37c4288. Read the comment docs.

@matthewfeickert matthewfeickert marked this pull request as ready for review November 17, 2020 19:07
@matthewfeickert matthewfeickert added fix A bug fix tests pytest labels Nov 17, 2020
@matthewfeickert matthewfeickert merged commit 8b7648a into master Nov 17, 2020
@matthewfeickert matthewfeickert deleted the fix/fix-timing branch November 17, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix tests pytest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Test version is slow only on MacOS
1 participant