fix: Use root-binaries conda-forge package as build base #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyhf/pyhf-validation
PR 9As (pointed out by @kratsg)
root_base
doesn't doesn't copy any of the compiled C++ code over, a build that is based onroot_base
won't actually have a workingROOT
installation (thoughPyROOT
will work). As a result of this, base the build around theconda-forge
packageroot-binaries
instead which does include aROOT
runtime.The current
root_base
based image is551.49 MB
compressed, and thisroot-binaries
build is568.43 MB
compressed, so I think the size increase isn't too bad.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: