Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use root-binaries conda-forge package as build base #5

Merged
merged 6 commits into from
Mar 16, 2020

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Mar 16, 2020

As (pointed out by @kratsg) root_base doesn't doesn't copy any of the compiled C++ code over, a build that is based on root_base won't actually have a working ROOT installation (though PyROOT will work). As a result of this, base the build around the conda-forge package root-binaries instead which does include a ROOT runtime.

The current root_base based image is 551.49 MB compressed, and this root-binaries build is 568.43 MB compressed, so I think the size increase isn't too bad.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Base build around conda-forge 'root-binaries' to get ROOT runtime
* Add checks to build CI for ROOT, hist2workspace, and common utilities

@matthewfeickert matthewfeickert added the fix A bug fix label Mar 16, 2020
@matthewfeickert matthewfeickert self-assigned this Mar 16, 2020
@matthewfeickert matthewfeickert added build Changes that affect the build system or external dependencies CI CI systems, GitHub Actions labels Mar 16, 2020
@matthewfeickert
Copy link
Member Author

matthewfeickert commented Mar 16, 2020

@henryiii and @chrisburr, if you have suggestions on additional libs to remove that would be welcome info.

@matthewfeickert matthewfeickert merged commit f2c5744 into master Mar 16, 2020
@matthewfeickert matthewfeickert deleted the fix/add-ROOT-to-path branch March 16, 2020 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies CI CI systems, GitHub Actions fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

root_base based build doesn't have root in PATH
2 participants