-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
root_base based build doesn't have root in PATH #4
Comments
@kratsg has pointed out that |
I would suggest using: "root_base=$ROOT_VERSION" \
"root-binaries" \ For a little more context,
If you see any crashes from missing dependencies that aren't obvious, ping me and I can probably guess what you're missing. Our curiosity, how does this change the compressed image size? If it's still notably larger I can try and look in to why if you can push both images somewhere (CERN GitLab's container registry?). |
Thanks very much for being so willing to help, @chrisburr. I really appreciate this information. However, we were able to get a ROOT source build working in PR #7, which gets us down to a current compressed image size of 352.03 MB.
When using the |
In
pyhf/pyhf-validation
PR 9 is was discovered that the current build doesn't haveroot
orhist2workspace
inPATH
even though Python knows about PyROOT. This is curious and seems to be a direct effect of that fact that aroot_base
build is used, as ifroot_base
pyhf-validation-root-base/Dockerfile
Lines 14 to 15 in d7e3ad6
is replaced with
root
then everything proceeds as normal withroot
orhist2workspace
inPATH
.It seems that something basic is being missed, and that @henryiii and @chrisburr might be able to give some guidance here.
The text was updated successfully, but these errors were encountered: