WIP: Redirect C stdout & stderr to log #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to handle redirection from C DRMAA implementations to the Python logger.
Make sure that we have some way configured for logging from `drmaa` generally.
This is needed for logging C stdout and stderr messages.
To ensure that information printed from the underlying DRMAA implementation is not lost, capture the C `stdout` and `stderr` information and log it using our logger. That way this can be handled like any other logging information in a cluster environment.
|
It looks like this is failing on python 2.6 because there's no |
|
Wouldn't worry about Python 2.6 as it was dropped upstream. The main issue was it wasn't capturing the C stdout/stderr when testing it locally. So there's probably more to do here, but haven't looked into what is needed recently. If you have time/interest to explore this issue, that would be very helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69
Captures C's
stdoutandstderrand logs it instead. Useful if the DRMAA implementation prints log messages out that one would like to capture.