-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more uniforms to .snapshot() #37
Conversation
looks like some other stuff broke too... will have a look later |
little lost on the CI thing for screenshots here. it seems to not collect any tests ( 0 out of 1) for this workload... It should be 22 collected and 1 selected instead. remaining more things to try:
In light of #31 and the potential to remake this whole thing in the future, I had hoped to find a small patch to make this |
You could try printing the full stdout & stderr of the subprocess in |
so... it turns out it was this alternative drivers that caused a panic somehow (your review comment about it vanished). Which is why there are differences between the two workflows. So wgpu-py removed this from will add the docs and this should be good |
Also fixes #34 by keeping the fractional part.
by skipping the
._update()
method foroffscreen=True
variant we can easily set most of the uniforms in the snapshot method. Should make this very close to deterministic.note: whole offscreen and snapshot situation needs a rework, as there are recent improvements in wgpu-py that should make it easier. But will look into that at a later date, the current implementation will do.