-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wgpu dependency to match pygfx #32
Conversation
I think the code picks the method to call based on |
The current problem I'm trying to address is that if you try to co-install this with the latest version of pygfx they require different versions and there isn't any intersection. I was hoping this would be a one line fix but I understand if there are other priorities that would create a conflict! |
I think wgpu 0.15 is fine to use, just 0.16 is needed for CI. Maybe if we use different requirements for the dev option while allowing broader wgpu-py versions for runtime deps. Maybe like pygfx/pygfx#786 pip might complain but nothing happens. since v0.20 never released for wgpu-native and we already have wgpu-core releasing 22.0 I hope that a jump to wgpu 22 reaches wgpu-py soonish since a bunch of interesting stuff is in there that will be useful for shadertoy |
This is what I was referring to: https://github.com/pygfx/pygfx/blob/eaf8acd4e4188b8f32302413984829b86497bf1f/pygfx/renderers/wgpu/engine/shared.py#L270-L273 |
@Vipitis i've reverted my changes, cherry-picked yours, and fixed it a little bit. I think having 0.15.1 compatibility in the test suite is only going to hurt maintenance given the limited resources we all have ;) |
Thank you whoever triggered the job. CI failured being addressed in #33 |
I tried examples/shadertoy_glsl_sdf.py it worked as well as a few others from that directory