Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wgpu dependency to match pygfx #32

Merged
merged 2 commits into from
Jul 21, 2024
Merged

Conversation

hmaarrfk
Copy link
Contributor

I tried examples/shadertoy_glsl_sdf.py it worked as well as a few others from that directory

@Vipitis
Copy link
Collaborator

Vipitis commented Jul 21, 2024

I also have this in #30 but going directly to 0.16 as there is one change needed in the testutils see: 6e67f7e

what is the current solution in pygfx for supporting 0.15 and 0.16?

@hmaarrfk hmaarrfk closed this Jul 21, 2024
@Korijn
Copy link
Contributor

Korijn commented Jul 21, 2024

I think the code picks the method to call based on wgpu.__version__

@hmaarrfk
Copy link
Contributor Author

The current problem I'm trying to address is that if you try to co-install this with the latest version of pygfx they require different versions and there isn't any intersection.

I was hoping this would be a one line fix but I understand if there are other priorities that would create a conflict!

@Vipitis
Copy link
Collaborator

Vipitis commented Jul 21, 2024

I think wgpu 0.15 is fine to use, just 0.16 is needed for CI. Maybe if we use different requirements for the dev option while allowing broader wgpu-py versions for runtime deps. Maybe like pygfx/pygfx#786 pip might complain but nothing happens.

since v0.20 never released for wgpu-native and we already have wgpu-core releasing 22.0 I hope that a jump to wgpu 22 reaches wgpu-py soonish since a bunch of interesting stuff is in there that will be useful for shadertoy

@Korijn
Copy link
Contributor

Korijn commented Jul 21, 2024

@hmaarrfk
Copy link
Contributor Author

@Vipitis i've reverted my changes, cherry-picked yours, and fixed it a little bit.

I think having 0.15.1 compatibility in the test suite is only going to hurt maintenance given the limited resources we all have ;)

@hmaarrfk
Copy link
Contributor Author

Thank you whoever triggered the job.

CI failured being addressed in #33

@Vipitis Vipitis merged commit d231cb8 into pygfx:main Jul 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants