Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add root_weight to basicGNN for "skip connections" #9673

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

add root_weight to basicGNN for "skip connections" #9673

wants to merge 14 commits into from

Conversation

puririshi98
Copy link
Contributor

No description provided.

@puririshi98 puririshi98 self-assigned this Sep 17, 2024
@github-actions github-actions bot added the nn label Sep 17, 2024
@puririshi98 puririshi98 changed the title add root_weight to basicGNN for "skip connections" Draft: add root_weight to basicGNN for "skip connections" Sep 17, 2024
@puririshi98 puririshi98 changed the title Draft: add root_weight to basicGNN for "skip connections" add root_weight to basicGNN for "skip connections" Sep 17, 2024
@rusty1s rusty1s requested a review from wsad1 as a code owner September 25, 2024 03:58
@rusty1s
Copy link
Member

rusty1s commented Sep 25, 2024

Thanks, looks good. There is one last problem with to_hetero (which seems to be a bug in ToHeteroTransformer).

@puririshi98
Copy link
Contributor Author

Thanks, looks good. There is one last problem with to_hetero (which seems to be a bug in ToHeteroTransformer).

i can take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s Awaiting requested review from rusty1s

@akihironitta akihironitta Awaiting requested review from akihironitta

@EdisonLeeeee EdisonLeeeee Awaiting requested review from EdisonLeeeee EdisonLeeeee is a code owner

@wsad1 wsad1 Awaiting requested review from wsad1 wsad1 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@puririshi98 puririshi98

Labels
nn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puririshi98 @rusty1s