Add codespell pre-commit-hook #9781
Open
+74
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
headtr1ck
added
the
Automation
|
Looks good! |
|
Does anyone have an idea why pre-commit fails in CI? It seems to ignore the skip of whats-new |
Illviljan
reviewed
Nov 17, 2024
| "PIE", # flake8-pie | ||
| "TID", # flake8-tidy-imports (absolute imports) | ||
| "PGH", # pygrep-hooks | ||
| "F", # Pyflakes |
There was a problem hiding this comment.
Doesn't black usually do 2 whitespaces for comments?
There was a problem hiding this comment.
Oh, good question.
I shouldn't have even formatted this even, but pre-commit did that ;)
There was a problem hiding this comment.
which hook was that? As far as I can tell, we don't have anything that would format TOML (yet, we can totally change that).
There was a problem hiding this comment.
Oh, might have been format on save in vscode.
I will have to check that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the large codebase there were surprisingly few misspellings.
But even better to add a pre-commit hook for that :)