Attempt to fix Heisenbug by skipping COO. #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hameerabbasi
added
the
bug
hameerabbasi
changed the title
CodSpeed Performance ReportMerging #813 will degrade performances by 16.47%Comparing Summary
Benchmarks breakdown
|
mtsokol
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
Please explain your changes below.
This PR fixes a Heisenbug introduced by the 3D COO test, which often caused the
sparse_vectortest (which is the next test to be executed) to fail.The reason for this was that the COO test was sometimes writing to memory it shouldn't be, IMO. Just another case of COO being broken.