Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update finch-tensor-python to fix tests #812

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

willow-ahrens
Copy link
Collaborator

This should fix finch-tensor/Finch.jl#644

@willow-ahrens
Copy link
Collaborator Author

@hameerabbasi it looks like this fixes the CI regression for Finch. The failure is an unrelated issue that the MLIR backend is wrong on Ubuntu.

Copy link

codspeed-hq bot commented Nov 19, 2024

CodSpeed Performance Report

Merging #812 will degrade performances by 19.91%

Comparing willow-ahrens-patch-CI-1 (20dc56b) with main (f69a0c0)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 338 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main willow-ahrens-patch-CI-1 Change
test_index_slice[side=100-rank=2-format='gcxs'] 2.4 ms 3 ms -19.91%
test_elemwise[f=<built-in function gt>-backend='Finch'-side=500] 65,641.4 µs 910.3 µs ×72

@hameerabbasi
Copy link
Collaborator

Thanks for the quick fix, @willow-ahrens!

@hameerabbasi hameerabbasi merged commit b7b2e67 into main Nov 19, 2024
16 of 19 checks passed
@hameerabbasi hameerabbasi deleted the willow-ahrens-patch-CI-1 branch November 19, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finch.jlregressions
2 participants