-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Array.asformat
method and add back reshape
function.
#800
Conversation
hameerabbasi
commented
Oct 24, 2024
- Fix signed/unsigned integer naming mix-up.
- Add mechanism for detecting output format.
CodSpeed Performance ReportMerging #800 will not alter performanceComparing Summary
|
1f5df6b
to
e75c724
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As #799 is now merged let's rebase it and also include COO in the determine_format
function. I think that it could be COO+COO=COO
and CSR+CSR=CSR
etc.
88bfd5f
to
4e0fe38
Compare
Right now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The progress looks good! One more round of comments.
1855c77
to
540bc4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's the last round of review - I think test_reshape
should be refined to cover most of reasonable scenarios.
And let's push another commit instead of force push.
reshape
Array.asformat
method and dd back reshape
function.
Array.asformat
method and dd back reshape
function.Array.asformat
method and add back reshape
function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for the thorough review, @mtsokol! |