Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add doctests to CI again. #767

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ci: Add doctests to CI again. #767

wants to merge 3 commits into from

Conversation

hameerabbasi
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • 🪄 Feature
  • 🐞 Bug Fix
  • 🔧 Optimization
  • 📚 Documentation
  • 🧪 Test
  • 🛠️ Other

Related issues

  • Related issue #
  • Closes #

Checklist

  • Code follows style guide
  • Tests added
  • Documented the changes

Please explain your changes below.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 3, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #767 will improve performances by ×2.1

Comparing hameerabbasi:doctests-2 (91a12fa) with main (7f31435)

Summary

⚡ 2 improvements
✅ 338 untouched benchmarks

Benchmarks breakdown

Benchmark main hameerabbasi:doctests-2 Change
⚡ test_index_fancy[side=100-rank=1-format='coo'] 1,395.6 µs 679.6 µs ×2.1
⚡ test_index_slice[side=100-rank=2-format='gcxs'] 2.9 ms 2.4 ms +23.71%

@hameerabbasi
Copy link
Collaborator Author

@willow-ahrens Doctest issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hameerabbasi