Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to Array API version 2023.12. #696
base: main
Are you sure you want to change the base?
Move to Array API version 2023.12. #696
Changes from 1 commit
59daf9d
42c9bfd
a2e84d5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we shouldn't import them to the main namespace. Let's keep them in
__array_namespace_info__
only.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current array API tests require these in the main namespace as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm then I think it's a bug in the
array-api-tests
suite.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Array API standard doesn't say they need to be in the main namespace: https://data-apis.org/array-api/latest/API_specification/inspection.html#inspection-apis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Demonstrated the failure in 42c9bfd, let's wait for
array-api-tests
fixes as you suggest.Check warning on line 175 in sparse/numba_backend/__init__.py
Codecov / codecov/patch
sparse/numba_backend/__init__.py#L175
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
unstack
is new - let's add a test for it.Check warning on line 2156 in sparse/numba_backend/_common.py
Codecov / codecov/patch
sparse/numba_backend/_common.py#L2155-L2156
Check warning on line 2160 in sparse/numba_backend/_common.py
Codecov / codecov/patch
sparse/numba_backend/_common.py#L2158-L2160
Check warning on line 2162 in sparse/numba_backend/_common.py
Codecov / codecov/patch
sparse/numba_backend/_common.py#L2162
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to test these functions. Let's add simple tests, like in NumPy: https://github.com/numpy/numpy/pull/26572/files#diff-db073cec9b943fac08cf9720c471d90dcbb7a0e00f4717433314ec95bee60fe2
Check warning on line 59 in sparse/numba_backend/_info.py
Codecov / codecov/patch
sparse/numba_backend/_info.py#L59
Check warning on line 63 in sparse/numba_backend/_info.py
Codecov / codecov/patch
sparse/numba_backend/_info.py#L63
Check warning on line 70 in sparse/numba_backend/_info.py
Codecov / codecov/patch
sparse/numba_backend/_info.py#L68-L70
Check warning on line 74 in sparse/numba_backend/_info.py
Codecov / codecov/patch
sparse/numba_backend/_info.py#L74
Check warning on line 80 in sparse/numba_backend/_info.py
Codecov / codecov/patch
sparse/numba_backend/_info.py#L79-L80
Check warning on line 82 in sparse/numba_backend/_info.py
Codecov / codecov/patch
sparse/numba_backend/_info.py#L82
Check warning on line 85 in sparse/numba_backend/_info.py
Codecov / codecov/patch
sparse/numba_backend/_info.py#L84-L85
Check warning on line 88 in sparse/numba_backend/_info.py
Codecov / codecov/patch
sparse/numba_backend/_info.py#L87-L88
Check warning on line 90 in sparse/numba_backend/_info.py
Codecov / codecov/patch
sparse/numba_backend/_info.py#L90
Check warning on line 93 in sparse/numba_backend/_info.py
Codecov / codecov/patch
sparse/numba_backend/_info.py#L92-L93
Check warning on line 95 in sparse/numba_backend/_info.py
Codecov / codecov/patch
sparse/numba_backend/_info.py#L95
Check warning on line 615 in sparse/numba_backend/_sparse_array.py
Codecov / codecov/patch
sparse/numba_backend/_sparse_array.py#L613-L615