Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add long and short format to as_hex #93

Merged
merged 6 commits into from
Aug 30, 2023
Merged

Add long and short format to as_hex #93

merged 6 commits into from
Aug 30, 2023

Conversation

DJRHails
Copy link
Contributor

@DJRHails DJRHails commented Aug 25, 2023 •
edited by pydantic-hooky bot
Loading

Fixes #66

Selected Reviewer: @Kludex

@DJRHails DJRHails mentioned this pull request Aug 25, 2023
Closed
13 tasks
@codecov
Copy link

codecov bot commented Aug 25, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (092251d) 100.00% compared to head (34517c9) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #93   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          598       599    +1     
  Branches       152       152           
=========================================
+ Hits           598       599    +1
Files Changed Coverage Δ
pydantic_extra_types/color.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DJRHails
Copy link
Contributor Author

Should be good now - followed the same pattern as import imp for the Literal typing import, had to do some poking for coverage and mypy to be happy.

@DJRHails
Copy link
Contributor Author

please review

Kludex
Kludex requested changes Aug 25, 2023
View reviewed changes
pydantic_extra_types/color.py Outdated Show resolved Hide resolved
@pydantic-hooky pydantic-hooky bot assigned DJRHails and unassigned Kludex Aug 25, 2023
@DJRHails DJRHails requested a review from Kludex August 26, 2023 14:31
@DJRHails
Copy link
Contributor Author

ready for review

@DJRHails
Copy link
Contributor Author

please review - not used hooky before so forgive me the repeats

@pydantic-hooky pydantic-hooky bot assigned Kludex and unassigned DJRHails Aug 30, 2023
@yezz123
Copy link
Collaborator

yezz123 commented Aug 30, 2023

@Kludex i will merge this

@yezz123 yezz123 merged commit d7b0e4a into pydantic:main Aug 30, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yezz123 yezz123 yezz123 approved these changes

@Kludex Kludex Awaiting requested review from Kludex

Assignees

@Kludex Kludex

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 6 character only as_hex e.g. Color("red").as_hex(format="long") == #ff0000
3 participants
@DJRHails @yezz123 @Kludex