Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 added automatic syntax-upgrade hook ~ pyupgrade #229

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

janas-adam
Copy link
Contributor

see #219

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e186814) to head (94786de).
Report is 50 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #229    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           11        19     +8     
  Lines          685      1047   +362     
  Branches       169       253    +84     
==========================================
+ Hits           685      1047   +362     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yezz123 yezz123 linked an issue Oct 22, 2024 that may be closed by this pull request
@yezz123 yezz123 merged commit 9d4800f into pydantic:main Oct 22, 2024
20 checks passed
@samuelcolvin
Copy link
Member

@yezz123 we should just use Ruff for this, rather than adding extra tools. Please can you check with the Pydantic before merging stuff like this. You can always chat to us on the pydantic slack.

@samuelcolvin
Copy link
Member

we should revert this, and adjust the flags in the ruff config if necessary.

@yezz123
Copy link
Collaborator

yezz123 commented Oct 22, 2024

@yezz123 we should just use Ruff for this, rather than adding extra tools. Please can you check with the Pydantic before merging stuff like this. You can always chat to us on the pydantic slack.

Okay that makes sense can we by any chance create a channel in Slack for this extra packages so we can keep collaboration

@yezz123
Copy link
Collaborator

yezz123 commented Oct 22, 2024

we should revert this, and adjust the flags in the ruff config if necessary.

I will take care of that

@samuelcolvin
Copy link
Member

Okay that makes sense can we by any chance create a channel in Slack for this extra packages so we can keep collaboration

yes definitely, we'll create a channel in that workspace. cc @sydney-runkle

I will take care of that

Thanks so much.,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

automatic syntax upgrade hook
3 participants