Added support for AG-UI Multi-modal Messages #3715
Open
+415
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored code for better readability. Bumped version of ag-ui libs.
Collaborator
|
@bojan2501 Can you have a look at the missing test coverage please? |
DouweM
requested changes
Dec 12, 2025
| return cast('dict[str, Any]', state) | ||
|
|
||
| @classmethod | ||
| def _load_binary_part( |
Collaborator
There was a problem hiding this comment.
Please move private helper methods below the public ones that use them like load_messages
| url=part.url, | ||
| media_type=part.mime_type, | ||
| identifier=part.id, | ||
| vendor_metadata={'filename': part.filename}, |
Collaborator
There was a problem hiding this comment.
We can't do this this, this will be interpreted as video_metadata by GoogleModel
Author
There was a problem hiding this comment.
You mean we should drop this line:
vendor_metadata={'filename': part.filename}
…Modal-Messages-AG-UI
…Modal-Messages-AG-UI
Moved private helper methods below public ones. Removed part where vendor metadata is used to populate filename together with url.
Also refactored code, made helper function public. As the type checker was complaining.
Author
|
I think this is it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses 3558
Refactored code for better readability.
Bumped version of ag-ui libs.