-
Notifications
You must be signed in to change notification settings - Fork 185
Initial work on managed variables #1548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexmojaki
wants to merge
30
commits into
main
Choose a base branch
from
managed-variables
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
51d7e48
Initial work on managed variables
dmontagu ce01469
Add docstrings
dmontagu e30568d
Some renaming
dmontagu 166e158
Add some documentation
dmontagu bd0de1c
Use pydantic-ai
dmontagu c8c1d22
Add more docstrings
dmontagu dddcb7c
Make importing work without pydantic installed
dmontagu 10b7742
Address most recent feedback
dmontagu f7a31aa
Minor improvements
dmontagu 889281a
Fix imports failure when pydantic is installed
dmontagu e67159b
Add tests
dmontagu d114903
Merge branch 'main' into managed-variables
dmontagu c7e2d11
Fix stubs
dmontagu 565c587
test_config_serializable
alexmojaki 636636f
test_config_serializable
alexmojaki 40ae76e
Add scheduled rollouts
dmontagu d363e10
Add top-level var
dmontagu ffc636e
Add CLI for syncing variables
dmontagu 2620c85
Add CLI for validating variables
dmontagu e4ce576
Merge main
dmontagu 1b8c048
Set development version of pydantic to be less than main branch on gi…
dmontagu e57e195
Fix tests of stubs
dmontagu 6fd4f1e
Fix type checking
dmontagu 2e6acc6
Merge main
dmontagu 7382346
Fix type checking
dmontagu 0a4d0e6
Try getting test to pass
dmontagu 95e4b54
Update a comment and remove new stubs per Alex's feedback
dmontagu 8a37b15
Address more Alex feedback
dmontagu 74cff95
Remove TODO comment
dmontagu 5d3e20b
Comment out schedule-related stuff
dmontagu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having both VariablesOptions and VariablesConfig is worrying
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, I'm assuming you understand the difference between them, do you have a suggestion for alternative naming?