add FormattedText component #72
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 120 118 -2
=========================================
- Hits 120 118 -2 |
| None, serialization_alias='textFormat' | ||
| ) | ||
| # TODO, use pydantic-extra-types Color? | ||
| text_color: str | None = pydantic.Field(None, serialization_alias='color') |
There was a problem hiding this comment.
you need to use Union, not | to support older python.
demo/components_list.py
Outdated
| c.Div( | ||
| components=[ | ||
| c.Heading(text='FormattedText', level=2), | ||
| c.Markdown(text='`FormattedText` can be used to change the style of the text.'), |
There was a problem hiding this comment.
please add something like
this is particularly useful to avoid the overhead of loading the markdown renderer, or when you're including user generated content that you don't want to escape styling.
| @@ -56,7 +56,7 @@ class Text(pydantic.BaseModel, extra='forbid'): | |||
|
|
|||
|
|
|||
| class Paragraph(pydantic.BaseModel, extra='forbid'): | |||
| text: str | |||
| text: '_t.List[_t.Union[str, FormattedText, Link]]' | |||
There was a problem hiding this comment.
| text: '_t.List[_t.Union[str, FormattedText, Link]]' | |
| text: '_t.Union[str, _t.List[_t.Union[str, FormattedText, Link]]]' |
you need to support just str as well.
Then you need to update Paragraph and Button to render this.
I guess Text should also be changed.
| const style = { | ||
| backgroundColor, | ||
| color, | ||
| fontWeight: textFormat === 'bold' ? 'bold' : 'normal', |
There was a problem hiding this comment.
should probably be omitted, not normal if bold is not set.
| backgroundColor, | ||
| color, | ||
| fontWeight: textFormat === 'bold' ? 'bold' : 'normal', | ||
| fontStyle: textFormat === 'italic' ? 'italic' : 'normal', |
Yes please, can you help me with that? |
This is my PR proposal for #29