Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docs build command on different global and venv python versions #5360

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nikulpatel3141
Copy link

@nikulpatel3141 nikulpatel3141 commented Sep 8, 2024

Description

The build command in the docs fails when using a python venv with a different version to the global installation as python3-config will use the global one.

For example on a machine with global python 3.12 in a venv using python 3.11:

(venv) $ python3-config --extension-suffix  # .cpython-311-x86_64-linux-gnu.so

(venv) $ python3 -c 'import sysconfig; print(sysconfig.get_config_var("EXT_SUFFIX"))'  # .cpython-312-x86_64-linux-gnu.so

This silently causes a 'ModuleNotFound' error as the venv cannot import the generated pybind module.

Suggested changelog entry:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant