-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Use collections.abc.Callable #2999
base: main
Are you sure you want to change the base?
Conversation
typing.Callable is a deprecated alias to collections.abc.Callable.
typing.Callable is a deprecated alias to collections.abc.Callable.
typing.Callable is a deprecated alias to collections.abc.Callable.
typing.Callable is a deprecated alias to collections.abc.Callable.
typing.Callable is a deprecated alias to collections.abc.Callable.
typing.Callable is a deprecated alias to collections.abc.Callable.
typing.Callable is a deprecated alias to collections.abc.Callable.
typing.Callable is a deprecated alias to collections.abc.Callable.
typing.Callable is a deprecated alias to collections.abc.Callable.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2999 +/- ##
=======================================
Coverage 96.36% 96.37%
=======================================
Files 52 52
Lines 8751 8766 +15
Branches 1593 1595 +2
=======================================
+ Hits 8433 8448 +15
Misses 190 190
Partials 128 128 ☔ View full report in Codecov by Sentry. |
@j-t-1 Could you please have a look at the CI failure? |
typing.Callable is a deprecated alias to collections.abc.Callable.
typing.Callable is a deprecated alias to collections.abc.Callable.
typing.Callable is a deprecated alias to collections.abc.Callable.
@stefan6419846 yes. There are a lot of deprecations from typing, and this was trying one. This does not work, and do not know if can avoid the TYPE_CHECKING if statement:
This may be a new discussion of whether An option is closing this and waiting till after dropping Python 3.8, avoiding |
I have seen strange issues with some setups and testing in the past when used with Regarding Python 3.8: How does |
typing.Callable is a deprecated alias to collections.abc.Callable.
typing.Callable is a deprecated alias to collections.abc.Callable.