Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: Remove duplicated comments #2860

Merged
merged 2 commits into from
Sep 20, 2024
Merged

STY: Remove duplicated comments #2860

merged 2 commits into from
Sep 20, 2024

Conversation

j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Sep 20, 2024

These are the same as the next line exception messages. Also fix one typo.

These are the same as the next line exception messages.
Also fix one typo.
@j-t-1
Copy link
Contributor Author

j-t-1 commented Sep 20, 2024

@pubpub-zz the URL for class LZWDecode (line 375) does not exist. Can this be removed?

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.99%. Comparing base (36e1245) to head (15a7ef1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2860      +/-   ##
==========================================
- Coverage   95.99%   95.99%   -0.01%     
==========================================
  Files          51       51              
  Lines        8517     8516       -1     
  Branches     1699     1698       -1     
==========================================
- Hits         8176     8175       -1     
  Misses        200      200              
  Partials      141      141              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefan6419846
Copy link
Collaborator

A copy is available at https://github.com/katjas/PDFrenderer/blob/master/src/com/sun/pdfview/decode/LZWDecode.java for example.

These are the same as the next line exception messages.
Also fix one typo and change a link.
@pubpub-zz pubpub-zz merged commit a337664 into py-pdf:main Sep 20, 2024
13 checks passed
@j-t-1 j-t-1 deleted the filters branch September 20, 2024 10:39
pubpub-zz added a commit to pubpub-zz/pypdf that referenced this pull request Sep 29, 2024
## Version 5.0.1, 2024-09-29

### New Features (ENH)
- Add `full` parameter to PdfWriter constructor (py-pdf#2865)

### Bug Fixes (BUG)
- Update pyproject.toml with minimum Python version of 3.8 (py-pdf#2859)
- Cope with unbalanced delimiters in dictionary object (py-pdf#2878)
- Cope with encoding with too many differences (py-pdf#2873)
- Missing spaces in extract_text() method (py-pdf#1328) (py-pdf#2868)
- Tolerate truncated files and no warning when jumping startxref (py-pdf#2855)

### Robustness (ROB)
- Repair PDF with invalid Root object (py-pdf#2880)
- Continue parsing dictionary object when error is detected (py-pdf#2872)
- Merge documents with invalid pages in named destinations (py-pdf#2857)
- Tolerate comments(%) in arrays (py-pdf#2856)

### Documentation (DOC), Testing (TST), Code Style (STY), Developer Experience (DEV), Maintenance (MAINT)

- (py-pdf#2844), (py-pdf#2862), (py-pdf#2863), (py-pdf#2847), (py-pdf#2860), (py-pdf#2867), (py-pdf#2874), (py-pdf#2879)

[Full Changelog](py-pdf/pypdf@5.0.0...5.0.1)
@pubpub-zz pubpub-zz mentioned this pull request Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants