MAINT: Adopt allcontributors - close #82 #91
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview:
allcontributors
has support for severalcommitConvention
: https://allcontributors.org/docs/fr/bot/configurationSadly none of them is compatible with our own custom commit message convention 😓
We could either:
commitConvention=eslint
in.all-contributorsrc
, which means we have to allow commits with aDocs:
prefix in.github/scripts/check_pr_title.py
MAINT:
orDOC:
For devs who would like to follow this lead, the necesseray changes do not seem huge:
What do you think about this @MartinThoma? 🙂