Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Adopt allcontributors - close #82 #91

Merged
merged 2 commits into from
Dec 22, 2024
Merged

MAINT: Adopt allcontributors - close #82 #91

merged 2 commits into from
Dec 22, 2024

Conversation

Lucas-C
Copy link
Member

@Lucas-C Lucas-C commented Dec 16, 2024

Preview:
image

allcontributors has support for several commitConvention: https://allcontributors.org/docs/fr/bot/configuration

Sadly none of them is compatible with our own custom commit message convention 😓

We could either:

  • use commitConvention=eslint in .all-contributorsrc, which means we have to allow commits with a Docs: prefix in .github/scripts/check_pr_title.py
  • submit a feature request to https://github.com/all-contributors/cli, to allow for custom prefixes like MAINT: or DOC:

For devs who would like to follow this lead, the necesseray changes do not seem huge:

What do you think about this @MartinThoma? 🙂

@MartinThoma
Copy link
Member

It certainly looks nice 😄

we have to allow commits with a Docs: prefix in .github/scripts/check_pr_title.py

Fine to me 👍

We would also need to adjust the code for auto-creating the release notes.

@Lucas-C
Copy link
Member Author

Lucas-C commented Dec 22, 2024

We would also need to adjust the code for auto-creating the release notes.

Alright, I made the necessary changes.

Merging this PR now.

@Lucas-C Lucas-C merged commit 09a8e0f into main Dec 22, 2024
10 checks passed
@Lucas-C Lucas-C deleted the allcontributors branch December 22, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants