Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Added] Doc on generating Code128 Barcode #746

Merged
merged 3 commits into from
Mar 31, 2023
Merged

Conversation

ssavi-ict
Copy link

Checklist:

  • The GitHub pipeline is OK (green),
    meaning that both pylint (static code analyzer) and black (code formatter) are happy with the changes of this PR.

  • A unit test is covering the code added / modified by this PR

  • This PR is ready to be merged

  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@ssavi-ict ssavi-ict requested a review from Lucas-C as a code owner March 31, 2023 16:39
@ssavi-ict
Copy link
Author

@Lucas-C, Please have a look at this PR. And let me know of any further issues.

Thank You.

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (338977a) 92.70% compared to head (36906da) 92.70%.

❗ Current head 36906da differs from pull request most recent head c897247. Consider uploading reports for the commit c897247 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #746   +/-   ##
=======================================
  Coverage   92.70%   92.70%           
=======================================
  Files          27       27           
  Lines        7266     7266           
  Branches     1313     1313           
=======================================
  Hits         6736     6736           
  Misses        336      336           
  Partials      194      194           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Lucas-C
Copy link
Member

Lucas-C commented Mar 31, 2023

This is perfect!
Thank you @ssavi-ict 😊
Merging now

@Lucas-C Lucas-C merged commit 88b41b7 into py-pdf:master Mar 31, 2023
@Lucas-C
Copy link
Member

Lucas-C commented Mar 31, 2023

@allcontributors please add @ssavi-ict for documentation

@allcontributors
Copy link

@Lucas-C

I've put up a pull request to add @ssavi-ict! 🎉

@Lucas-C
Copy link
Member

Lucas-C commented Apr 1, 2023

Congratulations, it's published in fpdf2 documentation! 😊
https://pyfpdf.github.io/fpdf2/Barcodes.html#code128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc: provide an usage example of combining fpdf2 with python-barcode
2 participants