-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding Bengali tutorial #726
Conversation
@Lucas-C added Bengali Tutorial. |
Thank you for making this translation @ssavi-ict! Could you please also add a link in |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #726 +/- ##
==========================================
- Coverage 93.75% 92.78% -0.97%
==========================================
Files 26 27 +1
Lines 7009 7245 +236
Branches 1258 1307 +49
==========================================
+ Hits 6571 6722 +151
- Misses 260 332 +72
- Partials 178 191 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@Lucas-C updated |
Hello, @Lucas-C . Please let me know if there is any issue with this PR. I did not get any ack yet. |
Hi @ssavi-ict! You PR is excellent, thank you for submitting it 😊 The reason why I haven't merged it yet is that I am currently working on a big PR: #703
Would you be OK to adapt your PR in order to use the new version of this section 5, from the English tutorial? |
Hi, @ssavi-ict I am new to open source project . So, will you guide me on this project. I also wanna be a Competitive Programmer. So , would you help me how to start and where to start? |
Hi @ssavi-ict! Just a heads-up: PR #703 has been merged 😊 |
@Lucas-C Thanks for notifying me. Will start working on it soon. |
@Lucas-C Could you please check the current PR? Updated with recent Tutorial changes. |
This looks great! |
#267 Added Bengali Tutorial
Checklist:
The GitHub pipeline is OK (green),
meaning that both
pylint
(static code analyzer) andblack
(code formatter) are happy with the changes of this PR.A unit test is covering the code added / modified by this PR
This PR is ready to be merged
In case of a new feature, docstrings have been added, with also some documentation in the
docs/
folderA mention of the change is present in
CHANGELOG.md
By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.