-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature: Gradient patterns #1334
Conversation
Hi @andersonhc 🙂 This is related to #790? Thank you for tackling this! And wish you a merry christmas 🎅🎄 |
There are 2 types of patterns on the PDF specs. Type 1 (tiling patterns) are the repetition of images or text and type 2 (shading patterns) are gradients. I am only implementing gradients for now because I need this feature to proceed with #1305. I will comment on #790 to detail what has been done and what's missing to implement tiling patterns. This PR also open a path to implement the LinearGradient and RadialGradient SVG features, we can open a issue for that. Merry Christmas to you too. Enjoy the holidays. |
Awesome! |
I rebased this branch onto I made a few comments but I also approved this PR 👍 |
FYI:
|
Good job on this @andersonhc! 👍 Congrats, really nice addition 🙂 |
e.g. Fixes #0
Checklist:
Implement linear and radial gradients (Pattern/Shading)
Implement a class to handle named resources better
A unit test is covering the code added
A mention of the change is present in
CHANGELOG.md
Docstrings have been added
Documentation created in the
docs/
folderThis PR is ready to be merged
By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.