Pattern feature implementation #1041
Conversation
…s, squares, and circles in eitheran outer shape of a rectangle or a circle
fpdf/drawing.py
Outdated
| @property | ||
| def fill_pattern(self): | ||
| """The desired fill pattern for this path/group.""" | ||
| pass | ||
|
|
||
| @fill_pattern.setter | ||
| def fill_pattern(self, new): | ||
| """The desired fill pattern for this path/group.""" | ||
| pass | ||
|
|
There was a problem hiding this comment.
Those getter / setter do nothing, and are in fact not really needed if the property you introduced is public (no leading underscore)
|
Thank you for initiating a PR 👍 I converted it into a draft for now, as this seems still incomplete. |
Sorry! I should have made it a draft thank you! |
…nd circles in eitheran outer shape of a rectangle or a circle
…daouddd/fpdf2 into Pattern-Feature-Implementation
|
Hi @boushrabnd! I see that you have added extra commits following my last comment, but I haven't been back to you since last december... Are you still working on this feature? |
Hello Lucas! I apologies, unfortunately I haven't had the chance to work on it more since december as my university workload got a bit hectic. If you don't mind I can continue to work on it this summer? I understand if you would like someone else to take it on, but I would love to give it a second try if possible. Thank you for your patience |
I just realized I replied with my other account... this is to confirm that I am the same person lol |
That is 100% totally fine 🙂 |
|
Hi @boushrabnd 🙂 I think the summer is over now. I just wanted to know if you are still planning to work on this? 🙂 |
Apologies for the empty promise, this summer was more hectic than expected with a family situation. I think it'll be better to assign this task to someone else. Apologies for not letting you know earlier and thank you for your patience! |
No problem @boushrabnd 🙂 I'm closing this PR now. |
This PR attempts to implement the Pattern Feature described by Issue #790.
Our current approach is to follow the same pipeline as set_font(). We have broken down the task into the following subtasks:
Creating PDFpattern class
Adding the set_fill_pattern method
Creating PDFpattern objects and adding them to the PDF Pattern dictionary
Serializing the call to a pattern
Documentation
Tests
Checklist:
The GitHub pipeline is OK (green),
meaning that both
pylint(static code analyzer) andblack(code formatter) are happy with the changes of this PR.A unit test is covering the code added / modified by this PR
This PR is ready to be merged
In case of a new feature, docstrings have been added, with also some documentation in the
docs/folderA mention of the change is present in
CHANGELOG.mdBy submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.