Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Enhance code quality and cli module #19

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

MrFixThis
Copy link
Contributor

Improved screenshot capturing logic, enhanced helper functions and improved CLI argument parsing specification

Improved screenshot capturing logic, enhanced helper functions and improved
CLI argument parsing specification
@MrFixThis
Copy link
Contributor Author

Days ago I came across this project and I really like its concept, so here are some general improvements I made to the application.

Some of them are:

  • Improved cli argument parsing specification.
  • Some unit tests added to the args submodule.
  • Improved code readability and quality of the screenshot module.
  • Removed unnecessary heap alloctions for errors using anyhow crate.

All these details translate into better quality and speed.

@MrFixThis
Copy link
Contributor Author

I almost forgot. I've updated the README.md to add the new --file-path | -f positional argument in the section where the functionality to read the contents of a file is shown.

Please update the example screenshot.

@pwnwriter
Copy link
Owner

Hey @MrFixThis,

Thanks a ton for your help! You've really stepped up the game of HXN. awesome! Let's get that pr merged 😻

Cheers!

@pwnwriter pwnwriter merged commit 863726a into pwnwriter:main Sep 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants