Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probe-IPA Lias #886

Open
wants to merge 118 commits into
base: main
Choose a base branch
from
Open

Probe-IPA Lias #886

wants to merge 118 commits into from

Conversation

lkleisa
Copy link
Collaborator

@lkleisa lkleisa commented Apr 22, 2024

Implementation of frontend management for alignments + New Diagram of Alignments:

Information for Alignment:

  • Always from an objective to another objective or a keyResult
  • It's not possible, to create an Alignment from two objects, which are in the same team
  • The objects from the Alignment must be in the same quarter

Alignment Management in Objective-Dialog

  • Load Alignment-Possibilities on Objective-Dialog open
  • Display them in an option group
  • Option group opens on input focus
  • Add Alignment when selecting item in option group
  • Working edit and delete with help of input field
  • Typeahead for alignment possibilities in option group
  • On quarter change in Objective-Dialog, remove alignment in frontend model and load new possibilites for quarter
  • Option group sort: Team by name, for each: objective by name, for each: keyresult by name

Information for Diagram

  • Diagram contains Nodes for Objectives and KeyResults
  • Diagram changes when filter in header changes
  • Objective-Search in Header does only search for bubbles which are objectives
  • On bubble click, the sidepanel appears
  • It's possible to edit an object or add a checkin over the diagram sidepanel
  • The diagram does a full reload, if one object changes (too big effort to change one specific bubble svg)
  • The diagram does not affect the url, so it's not possible to send a link to the diagram
  • The library does to placement of the bubbles by its own
  • On side reload or change of one object, the diagram does a reload and the placement changes
  • On changes from network to overview, the diagram keeps its arrangement.
  • The objective contains an icon for the state, the keyresult only the background color (Phillip Leimgruber)

@lkleisa lkleisa self-assigned this Apr 22, 2024
@lkleisa lkleisa force-pushed the Probe-IPA-Lias branch 3 times, most recently from 26e7dec to d04f222 Compare April 29, 2024 08:38
@lkleisa lkleisa force-pushed the Probe-IPA-Lias branch 8 times, most recently from 2dde360 to fcf756b Compare May 29, 2024 12:03
@lkleisa lkleisa force-pushed the Probe-IPA-Lias branch 5 times, most recently from d9abcb5 to 3ad8a14 Compare May 30, 2024 11:04
@lkleisa lkleisa marked this pull request as ready for review May 30, 2024 12:16
@lkleisa lkleisa marked this pull request as draft June 3, 2024 08:20
@lkleisa lkleisa marked this pull request as ready for review June 3, 2024 09:16
@lkleisa lkleisa force-pushed the Probe-IPA-Lias branch 2 times, most recently from b5e474c to b34d987 Compare June 6, 2024 06:47
clean-coder
clean-coder previously approved these changes Jun 6, 2024
Copy link
Collaborator

@clean-coder clean-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hallo Lias,
habe den Server Teil angeschaut. Fazit: super gut umgesetzt. Ich habe noch ein paar Kommentare gemacht. Aus meiner Sicht könnte man da den Code noch etwas lesbarerer machen. Wenn du was davon umsetzten wäre das super ... aber Code passt sonst schon gut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants