Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added generic types for event payloads #202

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mdw19873
Copy link

What does this PR do?

Adds generic typings to all event triggering methods. This will allow developers to define payload interfaces and enforce them at compile time. This should be able to drop in without causing anyone issues.

Checklist

  • All new functionality has tests.
  • All tests are passing.
  • New or changed API methods have been documented.
  • npm run format has been run

CHANGELOG

  • [CHANGED] Updated TypeScript typings to add T = any for the data argument on the trigger(), triggerBatch(), and sendToUser() methods. As well as the BatchEvent interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant