Basic Data breakpoints #765
Conversation
|
This change is |
puremourning
force-pushed
the
data-breakpoints
branch
3 times, most recently
from
48a5679 to
51d0bad
Compare
puremourning
force-pushed
the
data-breakpoints
branch
from
51d0bad to
e6b80c4
Compare
| continue | ||
| if bp[ 'conn' ] != connection.GetSessionId(): | ||
| continue | ||
| if not bp[ 'info' ].get( 'dataId' ): |
There was a problem hiding this comment.
could 0 be a valid value?
| @@ -91,6 +91,7 @@ | |||
| 'delete': [ '<Del>' ], | |||
| 'set_value': [ '<C-CR>', '<leader><CR>' ], | |||
| 'read_memory': [ '<leader>m' ], | |||
| 'add_data_breakpoint': [ '<F9>' ], | |||
There was a problem hiding this comment.
this should probably be based on the mappings mode, but I'm not sure anyone uses anything other than HUMAN mode...
python3/vimspector/variables.py
Outdated
| variable: Expandable | ||
| view: View | ||
|
|
||
| variable, view = self._GetVariable( buf, line_num ) |
There was a problem hiding this comment.
I guess this is where we might decide that it's actually an expression data BP e.g. we add a watch like foo and we want a data bp on the foo variable, but we currently can only do it on the result of that expression.
We should also allow it from the command line like :VimspectorAddDataBreakpoint <expression>
I will probably need to implement that for CodeLLDB before it's worth adding to vimspector as I still haven't found an adapter that supports it.
There was a problem hiding this comment.
done for codelldb; turns out that lldb-dap (formerly lldb-vscode) supports partially (though it's buggy and doesn't implement the address/bytes extension)
puremourning
force-pushed
the
data-breakpoints
branch
from
c6f2078 to
bdf734a
Compare
puremourning
force-pushed
the
data-breakpoints
branch
from
95c50c4 to
34933c8
Compare
Works with CodeLLDB mostly for named things. Expressions don't seem to be supported by anyone. Fixed some state issues with the connections being retained across restarts in watches. ugh. so messy. Added access type question. Java debug adapter returns broken breakpoints info response
puremourning
force-pushed
the
data-breakpoints
branch
from
34933c8 to
a2031a4
Compare
Include the message provided by the server. This is useful in the case that watchpoint can't be set. Also track server status (VERIFIED, etc.) and print that.
Store the connection ID and data ID in the "qf" hack, then handle these commands trivially. Fix a bug where we never cleared out data breakpoints if there were none.
puremourning
force-pushed
the
data-breakpoints
branch
from
8af1a0f to
d472636
Compare
There was a problem hiding this comment.
Reviewed 7 of 14 files at r1, 4 of 8 files at r2, 8 of 8 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions
Also fix yet-another bug with empty data breakpoints lists not clearing previously set data breakpoints.
puremourning
force-pushed
the
data-breakpoints
branch
from
812771d to
c3bf6a7
Compare
There was a problem hiding this comment.
Reviewed 8 of 8 files at r5, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions
Works ok with lldb-dap and codelldb with this patch: vadimcn/codelldb#1161
basic usage: https://asciinema.org/a/f47vEkVI9FKisLPiAyfcC2LGW
not perfect.
Closes #524