TELECOM-9088: topology_hiding: force SIPS in contact header when needed #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benceszigeti
requested review from
bcnewlin,
ghmj2417,
evan-maloney-genesys,
DHennessyGenesys and
davidtrihy-genesys
|
Submitting for an initial review before opening an upstream PR. |
benceszigeti
force-pushed
the
TELECOM-9088
branch
from
603fdc4 to
1153353
Compare
https://www.rfc-editor.org/rfc/rfc3261.html#section-12.1.1 "If the request that initiated the dialog contained a SIPS URI in the Request-URI or in the top Record-Route header field value, if there was any, or the Contact header field if there was no Record-Route header field, the Contact header field in the response MUST be a SIPS URI."
benceszigeti
force-pushed
the
TELECOM-9088
branch
from
1153353 to
31749ea
Compare
benceszigeti
commented
Dec 1, 2023
| @@ -408,6 +429,8 @@ static int topo_dlg_replace_contact(struct sip_msg* msg, struct dlg_cell* dlg) | |||
| } else { | |||
| ct_username = ctu.user.s; | |||
| ct_username_len = ctu.user.len; | |||
| ct_type = ctu.type; | |||
| if (ct_type == SIPS_URI_T) prefix_len += 1; | |||
There was a problem hiding this comment.
If RURI and Top RR are sip:, meanwhile the Contact header is sips:, then we should send out sip: in the Contact header if I understand correctly (Contact header only matter when RR is empty). In that case, this part may be broken, as it will calculate with the length of sips:, but later, it will send out sip: with it. I have to rethink this part.
benceszigeti
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rfc-editor.org/rfc/rfc3261.html#section-12.1.1
“If the request that initiated the dialog contained a SIPS URI in the
Request-URI or in the top Record-Route header field value, if there was
any, or the Contact header field if there was no Record-Route header
field, the Contact header field in the response MUST be a SIPS URI.”